Skip to content

fix(cli): render sub-millisecond timer inputs correctly in dora node info #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 1 commit into from
Aug 11, 2026
Merged

fix(cli): render sub-millisecond timer inputs correctly in dora node info #2859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions binaries/cli/src/command/node/info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,18 +230,16 @@ fn build_input_info(node_desc: &dora_message::descriptor::Node) -> Vec<InputInfo
node_desc
.inputs
.iter()
.map(|(input_id, input)| {
let source = match &input.mapping {
InputMapping::User(user) => format!("{}/{}", user.source, user.output),
InputMapping::Timer { interval } => {
format!("dora/timer/millis/{}", interval.as_millis())
}
mapping @ InputMapping::Logs(_) => mapping.to_string(),
};
InputInfo {
id: input_id.to_string(),
source,
}
.map(|(input_id, input)| InputInfo {
id: input_id.to_string(),
// Use `InputMapping`'s canonical `Display` rather than re-deriving the
// source string here. The previous hand-rolled
// `dora/timer/millis/{interval.as_millis()}` truncated any
// sub-millisecond timer (e.g. a `dora/timer/hz/2000` = 500µs input)
// to `dora/timer/millis/0`, a nonsensical zero-interval source;
// `Display` picks the coarsest exact unit and round-trips through the
// descriptor parser.
source: input.mapping.to_string(),
})
.collect()
}
Expand Down