Skip to content

Fix many-to-many embedCount() when multiple relations are eager loaded #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techmahedy merged 1 commit into from
Jun 4, 2026
Merged

Fix many-to-many embedCount() when multiple relations are eager loaded #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Phaseolies/Database/Entity/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1678,7 +1678,9 @@ protected function loadRelationCount(Collection $collection, string $relation, ?
$relationType = $firstModel->getLastRelationType();
$relatedModel = $firstModel->getLastRelatedModel();
$foreignKey = $firstModel->getLastForeignKey();
$localKey = $firstModel->getLastLocalKey();
$localKey = $relationType === "bindToMany"
? $firstModel->getKeyName()
: $firstModel->getLastLocalKey();

// Collect all local keys
$localKeys = array_map(fn($model) => $model->{$localKey}, $models);
Expand Down Expand Up @@ -1710,7 +1712,7 @@ protected function loadRelationCount(Collection $collection, string $relation, ?
// Set the count on each model
$countAttribute = $relation . '_count';
foreach ($models as $model) {
$key = $model->{$localKey};
$key = $model->getKey();
$model->{$countAttribute} = $counts[$key] ?? 0;
}
}
Expand Down Expand Up @@ -1738,7 +1740,6 @@ protected function loadManyToManyCount(Collection $collection, string $relation,
$foreignKey = $firstModel->getLastForeignKey();
$relatedKey = $firstModel->getLastRelatedKey();
$pivotTable = $firstModel->getLastPivotTable();
$localKey = $firstModel->getLastLocalKey();

$relatedModelInstance = new $relatedModel();
$relatedTable = $relatedModelInstance->getTable();
Expand Down Expand Up @@ -1768,7 +1769,7 @@ protected function loadManyToManyCount(Collection $collection, string $relation,
// Set the count on each model
$countAttribute = $relation . '_count';
foreach ($models as $model) {
$key = $model->{$localKey};
$key = $model->getKey();
$model->{$countAttribute} = $counts[$key] ?? 0;
}
}
Expand Down
Loading