Fix inverted token expiration check before API requests - #36
Merged
Conversation
as473
force-pushed
the
fix/token-expiration-check
branch
from
May 7, 2026 08:36
ef00ee7 to
fefbe12
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 99.33% 99.00% -0.34%
==========================================
Files 4 4
Lines 301 301
==========================================
- Hits 299 298 -1
- Misses 2 3 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
I use the library in HA and there the issue did not pop up, as the expiration is already tested in the HA. Furthermore, due to the second test on L74 it did not renew the login on each data update attempt either. Nice catch, thank you! |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The access token was not renewed after its expiration date.