Skip to content

Fix inverted token expiration check before API requests - #36

Merged
dontinelli merged 1 commit into
dontinelli:mainfrom
as473:fix/token-expiration-check
May 11, 2026
Merged

Fix inverted token expiration check before API requests#36
dontinelli merged 1 commit into
dontinelli:mainfrom
as473:fix/token-expiration-check

Conversation

@as473

@as473 as473 commented May 7, 2026

Copy link
Copy Markdown
Contributor

The access token was not renewed after its expiration date.

@as473
as473 force-pushed the fix/token-expiration-check branch from ef00ee7 to fefbe12 Compare May 7, 2026 08:36
@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.00%. Comparing base (afa5033) to head (fefbe12).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   99.33%   99.00%   -0.34%     
==========================================
  Files           4        4              
  Lines         301      301              
==========================================
- Hits          299      298       -1     
- Misses          2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dontinelli

Copy link
Copy Markdown
Owner

I use the library in HA and there the issue did not pop up, as the expiration is already tested in the HA. Furthermore, due to the second test on L74 it did not renew the login on each data update attempt either. Nice catch, thank you!

@dontinelli
dontinelli merged commit 24e7fc6 into dontinelli:main May 11, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants