Conversation
* editable config * do not use inherited preference class * expand defaults for transit relay * add cancel button and update dart_wormhole_william * improve styling * fix formatting * combine header with value and edit button. * Derive themes and use editable fields for desktop * remove Fimber logging * fix declaration of dark theme * cleanup * Improve prefs editor layout * Do not update preference when choosing default value * add widget test * also test multiple defaults * formatting * Fix Version for Targets which do not define versionCode * format * add configurable validation * Allow ws scheme * add test for Version * format * add generated mocks file * cleanup * fix preference text overflow * update dart module * fix not handling Uri parsing exceptions * trim input strings Co-authored-by: Donatas Puidokas <104410044+donpui@users.noreply.github.com>
…ios-build-improvements
Ios build improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review Checklist