Skip to content

fix: append proper network config to task - #24

Open
rakesh-dhakad07 wants to merge 1 commit into
donaldpiret:masterfrom
rakesh-dhakad07:fix-task-network-config
Open

fix: append proper network config to task#24
rakesh-dhakad07 wants to merge 1 commit into
donaldpiret:masterfrom
rakesh-dhakad07:fix-task-network-config

Conversation

@rakesh-dhakad07

@rakesh-dhakad07 rakesh-dhakad07 commented Oct 23, 2025

Copy link
Copy Markdown

Task network configuration like subnets, security groups and public ip are supported inside --network-configuration parameter.
here is the reference

Usage looks like:

with:
  action: run
  cluster: theClusterName
  target: taskName
  launch_type: FARGATE
  security_group: "securityGroupID"
  subnet: "subnetID"

@rakesh-gs

rakesh-gs commented Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown

@donaldpiret @sgarner Please have a look and let me know if any changes required

sgarner
sgarner reviewed Oct 23, 2025
View reviewed changes

@sgarner sgarner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this PR? It doesn't appear to add any new capability. 🤔

Comment thread entrypoint.sh
if [ -n "$INPUT_SUBNET" ]; then # Subnet
CMD="${CMD} --subnet ${INPUT_SUBNET}"
fi
if [ -n "$INPUT_SUBNET" ] && [ -n "$INPUT_SECURITY_GROUP" ]; then

@sgarner sgarner Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requiring both of these options to be set together is a (possibly breaking) change in behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sgarner sgarner sgarner left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rakesh-dhakad07 @rakesh-gs @sgarner