Skip to content

Feature/virtual towers - #28

Merged
domingom merged 14 commits into
developfrom
feature/virtual_towers
May 11, 2026
Merged

Feature/virtual towers#28
domingom merged 14 commits into
developfrom
feature/virtual_towers

Conversation

@jsauer-NCAR

Copy link
Copy Markdown
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]

    If yes, please describe:

Introduces virtual towers capability targeted in NCAR#108

Pull Request Testing

  • Describe testing already performed for these changes:

Exercised for ideal Example 2 with 5 towers spanning multiple ranks using cartesian coordinates. Also tested on large multiscale domain with multiple towers spanning multiple ranks using lat/lon coordinate specification. Post-processing script verified for the latter workflow across 19 towers.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

Documentation to be added to the NCAR feature.

  • Do these changes include sufficient testing updates? [Yes or No]
    N/A

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

No

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…device setup routine from BCs (moving into hydro_core), fix array names in Coriolis cleanup causing illegal memory access error.
…and Coriolis module/submodules and into the GRID module. Adds calculation and output of xoffSets and yOffsets for tower locations from cell-center coordinates. Fixed an issue with bad-indexing in the tower initial/static condition profile data.
…ciated with all tower coordinates in a towerSpecsFile.
…assuming lat/lon fields are provided in an initial conditions file.
… input file to convert raw binary tower data files into a single consolidated NetCDF file.
@jsauer-NCAR
jsauer-NCAR requested a review from domingom May 11, 2026 22:14
@domingom
domingom merged commit 4ee54c8 into develop May 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants