Feature/virtual towers - #28
Merged
Merged
Conversation
…device setup routine from BCs (moving into hydro_core), fix array names in Coriolis cleanup causing illegal memory access error.
…and Coriolis module/submodules and into the GRID module. Adds calculation and output of xoffSets and yOffsets for tower locations from cell-center coordinates. Fixed an issue with bad-indexing in the tower initial/static condition profile data.
…ciated with all tower coordinates in a towerSpecsFile.
…assuming lat/lon fields are provided in an initial conditions file.
… input file to convert raw binary tower data files into a single consolidated NetCDF file.
domingom
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Differences
If yes, please describe:
Introduces virtual towers capability targeted in NCAR#108
Pull Request Testing
Exercised for ideal Example 2 with 5 towers spanning multiple ranks using cartesian coordinates. Also tested on large multiscale domain with multiple towers spanning multiple ranks using lat/lon coordinate specification. Post-processing script verified for the latter workflow across 19 towers.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Documentation to be added to the NCAR feature.
Do these changes include sufficient testing updates? [Yes or No]
N/A
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
No
Pull Request Checklist