Modernize CodeQL and golangci-lint action versions#67
Merged
Conversation
The CodeQL and golangci-lint workflows were pinned to action versions
that GitHub has retired:
- actions/checkout@v2 (Node 12-based, retired)
- github/codeql-action/{init,autobuild,analyze}@v1 (v1 retired by GitHub)
- golangci/golangci-lint-action@v2 (from 2021)
These jobs were either silently failing or running in degraded mode,
producing a false static-analysis signal on every PR.
Changes:
- Bump actions/checkout to @v6 (matches the existing ci.yml convention).
- Bump github/codeql-action/* to @V3 (current stable major).
- Bump golangci/golangci-lint-action to @v6.
- Pin golangci-lint to v1.62.0. 'version: latest' picks up new linters
on every run, which can break unrelated PRs; a fixed version is
deterministic and bumped intentionally.
- Add actions/setup-go@v6 to the lint workflow, reading the Go version
from go.mod so the lint job exercises the same toolchain as the test
job.
Closes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CodeQL and golangci-lint workflows were pinned to action versions GitHub has retired:
actions/checkout@v2(Node 12-based, retired)github/codeql-action/{init,autobuild,analyze}@v1(v1 retired by GitHub)golangci/golangci-lint-action@v2(from 2021)These jobs were either silently failing or running in degraded mode, producing a false static-analysis signal on every PR.
Changes:
actions/checkoutto@v6in both workflows (matches the existingci.ymlconvention).github/codeql-action/*to@v3(current stable major).golangci/golangci-lint-actionto@v6.golangci-linttov1.62.0.version: latestpicks up new linters on every run, which can break unrelated PRs; a fixed version is deterministic and bumped intentionally.actions/setup-go@v6to the lint workflow, reading the Go version fromgo.modso the lint job exercises the same toolchain as the test job (Go 1.20 after Bubble errors up from worker goroutines; exit non-zero on failure #66).Test plan
gofmt -l .— no outputgo vet ./...— no outputgo build ./...— no outputgo test -race ./...— PASSCloses #27
Generated by Claude Code