Skip to content

Better Structure for Sass#5

Open
dolfelt wants to merge 2 commits into
masterfrom
feature/scss-structure
Open

Better Structure for Sass#5
dolfelt wants to merge 2 commits into
masterfrom
feature/scss-structure

Conversation

@dolfelt

@dolfelt dolfelt commented Aug 27, 2015

Copy link
Copy Markdown
Owner

Broke out the CSS files based on the 7-1 structure found here: http://sass-guidelin.es/#the-7-1-pattern

Still might need some tweaks, but a good start.

Fixes #4

@curtis1000 @shadowhand @ameech

@dolfelt dolfelt force-pushed the feature/scss-structure branch from 8b8159f to aa75765 Compare August 27, 2015 02:20
@dolfelt

dolfelt commented Aug 27, 2015

Copy link
Copy Markdown
Owner Author

Fixed the spacing issues for the lovely @shadowhand. 🎉

Comment thread sass/layout/_base.scss

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we start working on the actual UI, let's try not to nest further than three levels. Makes it harder to keep track of what's going on and styles become too specific. Also, it slows down rendering times having to parse through all of the selectors.

Using BEM should help alleviate this.

@dolfelt dolfelt force-pushed the feature/scss-structure branch from aa75765 to 18cc177 Compare August 27, 2015 02:32

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no more tables!!!

I like the idea of using Bootstrap's grid, heavily tested and quite versatile.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair though, a grid view of data is the perfect reason to use tables.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with that, it's very hard to make it look decent on mobile. Bootstrap has support for responsive tables, which would be handy.

@dolfelt dolfelt mentioned this pull request Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants