Add views collection tests#238
Merged
Merged
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (633+10 LOC, 7 files); LLM: Adds new compatibility test coverage for view collection semantics (read ops, write rejection, pipeline composition, chaining depth limits), with a small refactor to the ViewCollection helper in target_collection.py. If a label is wrong, remove it manually and ping |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
yshanhu
reviewed
May 29, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
The view depth limit boundary differs between engines, so testing the exact boundary is not a meaningful compatibility surface. The view-on-view composition test remains. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
yshanhu
approved these changes
May 30, 2026
eerxuan
approved these changes
Jun 1, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
eerxuan
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds general tests for views.
The aim here is to test the runtime semantics unique to views like source reflection (insert/update/delete visibility), pipeline composition with aggregate queries, view chaining with depth limit enforcement, read operation behavior (find, aggregate, distinct), and write rejection for unsupported operations.
The
ViewCollectionhelper intarget_collection.pywas refactored to accept a rawoptionsdict, making it easier to test arbitrary view configurations without needing to add a new field for each option.