Added query tests for $jsonSchema#169
Conversation
Signed-off-by: Victor [C] Tsang <vitsangp@amazon.com>
danielfrankcom
left a comment
There was a problem hiding this comment.
Comments are on the BSON type enumeration approach, as discussed here. Have not reviewed the $jsonSchema coverage specifically.
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (2397+1 LOC, 11 files); LLM: Adds new query test coverage for $jsonSchema operator plus a BSON type testing framework, touching test compatibility files across one component. If a label is wrong, remove it manually and ping |
eerxuan
left a comment
There was a problem hiding this comment.
I think this design is better for the argument testing. My updated design is still complex for argument type testing.
I think it's good idea to not have expected value list here, just verify pass. And separation of passing and failing cases is cleaner.
Signed-off-by: Victor [C] Tsang <vitsangp@amazon.com>
Signed-off-by: Victor [C] Tsang <vitsangp@amazon.com>
Signed-off-by: Victor [C] Tsang <vitsangp@amazon.com> Signed-off-by: Sarthak Dalmia <sadalmia@microsoft.com>
This PR contains:
Ref: