Skip to content

[subaction/matrix] Replace github-script with new package#454

Open
jeliebig wants to merge 4 commits into
docker:masterfrom
jeliebig:subaction-to-typescript
Open

[subaction/matrix] Replace github-script with new package#454
jeliebig wants to merge 4 commits into
docker:masterfrom
jeliebig:subaction-to-typescript

Conversation

@jeliebig

Copy link
Copy Markdown

Before I add the changes for #435, I'd like to move the subaction in its current state to a new package.

I didn't want to overwhelm you by creating a PR with all changes at once, so I'm trying to open smaller PRs.

I needed to adjust the original script minimally, so linting would pass.
I tested these changes locally by executing the ci-subaction workflow using nektos/act.

@jeliebig jeliebig force-pushed the subaction-to-typescript branch from 7ce8772 to c29e11f Compare May 28, 2026 20:26
@jeliebig

Copy link
Copy Markdown
Author

@crazy-max Sorry for the ping, may I know whether I'm missing something here or if I just need to wait for reviews?

@crazy-max

Copy link
Copy Markdown
Member

Hey @jeliebig! Sorry I missed your PRs, I will take a closer look asap

jeliebig added 4 commits July 2, 2026 15:38
Signed-off-by: Julian Liebig <julian.liebig@tudock.de>
Signed-off-by: Julian Liebig <julian.liebig@tudock.de>
Signed-off-by: Julian Liebig <julian.liebig@tudock.de>
Signed-off-by: Julian Liebig <julian.liebig@tudock.de>
@jeliebig jeliebig force-pushed the subaction-to-typescript branch from 74888c7 to f1df813 Compare July 2, 2026 13:44
@jeliebig

jeliebig commented Jul 2, 2026

Copy link
Copy Markdown
Author

Rebased

Comment thread dist/licenses.txt
The following npm packages may be included in this product:

- @sigstore/verify@4.1.0
- docker-buildx-bake-matrix@unknown

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be excluded if we add a config file for generate-license-file, but I'm not sure if you'd like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants