Rocket.Chat: fix: unsupported versions gap

[rocketchat-github-ci]

Pull Request: RocketChat/Docker.Official.Image#292

[yosifkit]

+Tags: 7.10.9, 7.10, 7
 
-Tags: 7.13.9, 7.13, 7

With the removal of 7.13.x and moving the 7 tag from 7.13 to 7.10, will that cause issues for anyone running 7 (7.13.9) and getting downgraded to 7.10.9 on their next pull?

[sampaiodiego]

good catch @yosifkit .. this is because 7.10 is an LTS version, so it will be supported for longer.. but I see the problem, I'll talk to my team to decide the best approach here.. I'll move the PR to draft meanwhile..

[github-actions]

Diff for 4f6a4ed:

diff --git a/_bashbrew-cat b/_bashbrew-cat
index cd77ea2..140c9b4 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -6,8 +6,16 @@ Tags: 7.10.9, 7.10
 GitCommit: 2f4945d910dade78b5d1ad6e5b7a351b7d6ae939
 Directory: 7.10
 
+Tags: 7.11.7, 7.11
+GitCommit: ab90642f634b4a480fdf33e020037a0974a76417
+Directory: 7.11
+
+Tags: 7.12.7, 7.12
+GitCommit: ab90642f634b4a480fdf33e020037a0974a76417
+Directory: 7.12
+
 Tags: 7.13.9, 7.13, 7
-GitCommit: 1c3e8bb69e9b09980e3129f201beaca6d65f756b
+GitCommit: ab90642f634b4a480fdf33e020037a0974a76417
 Directory: 7.13
 
 Tags: 8.0.7, 8.0
@@ -30,6 +38,10 @@ Tags: 8.4.4, 8.4
 GitCommit: 1c3e8bb69e9b09980e3129f201beaca6d65f756b
 Directory: 8.4
 
-Tags: 8.5.1, 8.5, 8, latest
+Tags: 8.5.1, 8.5
 GitCommit: 1c3e8bb69e9b09980e3129f201beaca6d65f756b
 Directory: 8.5
+
+Tags: 8.6.0, 8.6, 8, latest
+GitCommit: 5f8d60841f68e7f2335b47892b3079dbb10344fa
+Directory: 8.6
diff --git a/_bashbrew-list b/_bashbrew-list
index 7d253c2..63958cd 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,6 +1,10 @@
 rocket.chat:7
 rocket.chat:7.10
 rocket.chat:7.10.9
+rocket.chat:7.11
+rocket.chat:7.11.7
+rocket.chat:7.12
+rocket.chat:7.12.7
 rocket.chat:7.13
 rocket.chat:7.13.9
 rocket.chat:8
@@ -16,4 +20,6 @@ rocket.chat:8.4
 rocket.chat:8.4.4
 rocket.chat:8.5
 rocket.chat:8.5.1
+rocket.chat:8.6
+rocket.chat:8.6.0
 rocket.chat:latest
diff --git a/_bashbrew-list-build-order b/_bashbrew-list-build-order
index 612af32..977b6e6 100644
--- a/_bashbrew-list-build-order
+++ b/_bashbrew-list-build-order
@@ -1,8 +1,11 @@
 rocket.chat:7
 rocket.chat:7.10
+rocket.chat:7.11
+rocket.chat:7.12
 rocket.chat:8.0
 rocket.chat:8.1
 rocket.chat:8.2
 rocket.chat:8.3
 rocket.chat:8.4
+rocket.chat:8.5
 rocket.chat:latest
diff --git a/rocket.chat_7.10/Dockerfile b/rocket.chat_7.11/Dockerfile
similarity index 99%
copy from rocket.chat_7.10/Dockerfile
copy to rocket.chat_7.11/Dockerfile
index b57c9d7..1dd87f5 100644
--- a/rocket.chat_7.10/Dockerfile
+++ b/rocket.chat_7.11/Dockerfile
@@ -37,7 +37,7 @@ WORKDIR /app
 
 ENV NODE_ENV=production
 
-ENV RC_VERSION=7.10.9
+ENV RC_VERSION=7.11.7
 
 RUN set -eux \
   && apt-get update \
diff --git a/rocket.chat_7.10/Dockerfile b/rocket.chat_7.12/Dockerfile
similarity index 99%
copy from rocket.chat_7.10/Dockerfile
copy to rocket.chat_7.12/Dockerfile
index b57c9d7..dec1d40 100644
--- a/rocket.chat_7.10/Dockerfile
+++ b/rocket.chat_7.12/Dockerfile
@@ -37,7 +37,7 @@ WORKDIR /app
 
 ENV NODE_ENV=production
 
-ENV RC_VERSION=7.10.9
+ENV RC_VERSION=7.12.7
 
 RUN set -eux \
   && apt-get update \
diff --git a/rocket.chat_latest/Dockerfile b/rocket.chat_8.5/Dockerfile
similarity index 100%
copy from rocket.chat_latest/Dockerfile
copy to rocket.chat_8.5/Dockerfile
diff --git a/rocket.chat_latest/Dockerfile b/rocket.chat_latest/Dockerfile
index 257db2f..b552a1f 100644
--- a/rocket.chat_latest/Dockerfile
+++ b/rocket.chat_latest/Dockerfile
@@ -37,7 +37,7 @@ WORKDIR /app
 
 ENV NODE_ENV=production
 
-ENV RC_VERSION=8.5.1
+ENV RC_VERSION=8.6.0
 
 RUN set -eux \
   && apt-get update \

Relevant Maintainers:

• rocket.chat: @RocketChat

[sampaiodiego]

@yosifkit we decided to keep minor versions if there is a gap like this. we'll change our process to avoid those in the future. but for now I brought back previously removed versions.

[tianon]

We're missing a few details to provide better advice here, but what I've pieced together is that most of the 7.x versions are now EOL, but 7.10 in specific is LTS and supported until September? So maybe dropping the bare 7 alias now that 7.13 is EOL would be one option? Then it'd stay at 7.13 on Docker Hub (and no longer get rebuilds/updates), and telegraph to users that they should upgrade, if they check the supported versions.

What's the plan to deal with this gap in the future? ie, when 8.6 goes EOL and 8.5 is still LTS?

I guess 8.0 should be considered for removal too, as it's also EOL now?

[sampaiodiego]

7.10 in specific is LTS and supported until September? So maybe dropping the bare 7 alias now that 7.13 is EOL would be one option?

yes, 7.10 EOL is end of September. do you really think it is that bad publishing 7.11 and 7.12 back again? they won't receive any update.

What's the plan to deal with this gap in the future? ie, when 8.6 goes EOL and 8.5 is still LTS?

the plan is to have an LTS version before a major. so let's say we decide to publish 9.0 and the current 8.x version is 8.11, we will make 8.11 LTS.

I guess 8.0 should be considered for removal too, as it's also EOL now?

we consider end of month.. so end of July it will be EOL

[tianon]

I think publishing them again is fine, but leaving them published is not great because it explicitly telegraphs to users that they're actively supported when that's not true (any major vulnerability would be fixed in 7.10, but not 7.11 or 7.12, for example, despite them being listed as "supported" and even being actively rebuilt with base image updates).