CVE fix: Bumped up commons.io, junit + Java8 ready#4
Merged
Conversation
lc-nyovchev
commented
Jun 13, 2021
Owner
|
I'll take a look on monday. Java8 and bumping the dependencies should not be a problem here, so I expect this PR to be merged without too many problems |
Owner
|
Reviewed & looks good. Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves:
PR-107
PR-104
In the original (unmaintained repo).
I also thought it might be good to slightly modernize the repo by introducing java8 support (especially since
commons-io:2.5is the last version ofcommons-iocompatible with java 6).@dnovitski Please let me know if you think java 6 support is still relevant. and I'd revert most of the changes.