fix: Default frecency/history DB paths to ~/.pi/agent/fff/ (#474)#495
Open
gustav-fff wants to merge 1 commit into
Open
fix: Default frecency/history DB paths to ~/.pi/agent/fff/ (#474)#495gustav-fff wants to merge 1 commit into
gustav-fff wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #474
Root cause
packages/pi-fff/src/index.ts:305-312defaultedfrecencyDbPathandhistoryDbPathtoundefined. At the FFI boundary (packages/fff-node/src/finder.ts:112-113),undefinedbecomes empty string. Incrates/fff-c/src/lib.rs:210-211,optional_cstr("")returnsNone. WhenNone, frecency/query-tracker init skipped (lines 219-248), so both stay default uninitialized.Fix
Default both to
~/.pi/agent/fff/frecencyand~/.pi/agent/fff/history, matching README claim (line 152). Flag/env overrides unchanged.Steps to reproduce
Pre-fix (main):
Expected: frecency/history active, LMDB files created under
~/.pi/agent/fff/.Actual: both disabled, no files created.
Post-fix (this PR):
How verified
make lint: no errors in pi-fff.path.join(os.homedir(), ".pi", "agent", "fff")constructs correct base, thenfrecency/historyappended.undefinedwith concrete path.Automated triage via gustav-fff bot.