fix(shopify): remove stray debug print from partner GraphQL pagination#693
Merged
rudolfix merged 1 commit intoJul 3, 2026
Merged
Conversation
get_graphql_pages printed every raw API response page to stdout. For any real partner query that is pages of raw JSON written to the console (or an orchestrator's logs) on every run, and transaction data is not something to echo into logs by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShopifyPartnerApi.get_graphql_pagesprints every raw API response page to stdout. For any real partner query that means pages of raw JSON echoed to the console, or to an orchestrator's logs, on every scheduled run — and partner transaction data isn't something to write into logs by default.One line removed, no behaviour change otherwise. Spotted while building a Shopify pipeline with dlt and reading the verified source for reference.