fix: ignore pgoutput Type messages#691
Open
fengjikui wants to merge 1 commit into
Open
Conversation
roberto-palloni
approved these changes
Jun 29, 2026
|
Hello! Do you have an estimate on how long would it take to merge and in which version it will be available? Thanks |
Author
|
I do not have a maintainer-side ETA for merge or release version. From the author side, the PR is mergeable and has an approval; the remaining workflow checks visible to me are skipped because this is a fork PR, so the next step depends on maintainer-side review/CI/merge handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Postgres pgoutput can emit
YType messages when custom types are present in the publication stream.MessageConsumercurrently treats any unrecognized op as fatal, so a Type message raisesValueError: Unknown replication op 89even though it does not contain row changes.This PR makes
MessageConsumerignore op89/Yand adds a small regression test for that no-op behavior.Addresses dlt-hub/dlt#4102.
Validation
uv run pytest tests/pg_replication/test_pg_replication.py::test_message_consumer_ignores_type_message -quv run black --check sources/pg_replication/helpers.py tests/pg_replication/test_pg_replication.pyuv run flake8 --extend-ignore=W503 sources/pg_replication/helpers.py tests/pg_replication/test_pg_replication.pyNote: plain
uv run flake8 sources/pg_replication/helpers.py tests/pg_replication/test_pg_replication.pystill reports pre-existing W503 line-break warnings in unchanged lines; no new lint issues are introduced by this patch.