Map Pipedrive V2 custom fields#687
Open
srl-git wants to merge 2 commits into
Open
Conversation
Collaborator
|
it is tested once and works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell us what you do here
Short description
Adds optional custom field mapping for Pipedrive V2 resources.
When
map_custom_fields=Trueis passed topipedrive_v2_source, supported V2 resources fetch their field metadata from the corresponding V2 field endpoint and use it to rename hashedcustom_fieldskeys into readable top-level columns. Enum and set option IDs are mapped to labels using the existing custom field mapping behavior.The mapping is opt-in to avoid changing existing V2 destination schemas by default. Field mappings are also stored in source state, so if a Pipedrive custom field is renamed later, future loads continue writing to the original normalized column name instead of creating a new column.
Related Issues
Fixes #683
Additional Context
I have read the contributing guide and run the tests locally.
Local checks run:
uv run pytest tests/pipedrive/test_pipedrive_source.pymake lint-code