fix(minimal-workspace): remove the no-op copy logs/traces buttons from the onboarding notebook#68
Merged
Merged
Conversation
…the onboarding notebook A read-only notebook can't reach the pipeline's trace (last_trace lives where the pipeline ran, not in the serve job), and the platform runs API exposes only a logs link, no trace — so those buttons copied "[No pipeline logs available]" placeholder text. Removed the copy affordance, its dead helpers, the logs/traces traits and pipeline_logs/pipeline_trace stubs; rebuilt the session snapshot. FK-target tooltips (attachTip) and the page-3 prompt-copy button are unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bjoaquinc
force-pushed
the
fix/remove-notebook-copy-buttons
branch
from
771ea1a to
0e8bd4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The onboarding notebook's "Copy logs" / "Copy traces" buttons only ever copied placeholder text (
"[No pipeline logs available]"). A read-only notebook can't reach the pipeline's trace —pipeline.last_tracelives where the pipeline ran, not in the serve job — and the platform runs API exposes only a logs link, no trace structure. So there's nothing real for them to copy today; removing them until the platform can serve trace data to read-only sessions.Changes
schema_overview.py, along with the now-dead helpers (makeMenu,copyText/legacyCopy,toast, the copy SVGs) and their CSS.logs/traceswidget traits, their wiring inonboarding_success.py, and thepipeline_logs/pipeline_tracestubs indlt_access.py.attachTip) and the page-3 prompt-copy button (that one copies a real prompt).Tests
marimo_versionstill matches the lock.