feat(scaffold): pin workspace Python via committed .python-version#67
Merged
Conversation
Ship a .python-version (3.13) in the minimal workspace so a new workspace gets a self-contained, reproducible venv — uv auto-provisions the interpreter on 'uv sync'. Matches uv's own 'uv init' convention (commit the pin, don't ignore it); the scaffold .gitignore already doesn't ignore it. Mirrors the same change in dlthub-init. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ships a committed
.python-version(pinned to3.13) in the minimal workspace scaffold. New workspaces get a self-contained, reproducible venv — uv auto-provisions the interpreter onuv syncif it isn't installed.Mirrors the same change in dlthub-init, and matches uv's own convention:
uv initcreates a.python-version(default3.13) and deliberately doesn't gitignore it.Notes specific to this repo:
.gitignorealready doesn't ignore.python-version, so no.gitignorechange was needed here.3.13sits within the scaffold'srequires-python = ">=3.12"and matches the interpreter the bundled workspace already resolves to (.venv/lib/python3.13)..python-versionis not inBENIGN_ENTRIES, so the in-place-init invariant test is unaffected; thecopy_scaffoldcopy path (copytree+_ignore_runtime) ships root-level dotfiles as-is.Changes
src/create_dlthub_workspace/scaffolds/minimal_workspace/.python-version→3.13.tests/test_scaffold.py: assert the scaffolded workspace contains.python-version.[Unreleased] → Added.Testing
make test✅ (175 passed) — includes the newcopy_scaffoldassertion that the file lands in the output workspace.🤖 Generated with Claude Code