test(minimal-workspace): cover the onboarding notebook and .scripts helpers#63
Merged
Conversation
…elpers - tests for show_notebook/serve_headless (require a ref; show_notebook builds the show URL, honors DLTHUB_APP_URL, errors without workspace_id) and that scripts reference only a deployed job - guard the session snapshot: marimo_version matches the lock, no inlined anywidget data: URL, ships via copy_scaffold, all shipped .py compile - serve_headless checks its arg before importing dlt_runtime (fail-fast + testable without the runtime) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bjoaquinc
force-pushed
the
test/scaffold-notebook-coverage
branch
from
6589f80 to
20d0625
Compare
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bjoaquinc
force-pushed
the
test/scaffold-notebook-coverage
branch
from
20d0625 to
2bef92c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #62: adds the missing test coverage for the onboarding notebook scaffold and the
.scripts/helpers.Changes
show_notebook.py/serve_headless.py— both require a job ref;show_notebookbuilds the…/notebooks/<ref>/showURL, honorsDLTHUB_APP_URL, and errors withoutworkspace_id— plus a guard that the scripts only reference a job the scaffold actually deploys.marimo_versionmatches the lock, no inlined anywidgetdata:URL, ships viacopy_scaffold, and all shipped.pycompile.serve_headless.pynow checks its arg before importingdlt_runtime(fail-fast, and testable without the runtime installed).Tests
make scaffold-lock-checkpasses.