improvement(cli): coherent post-setup flow for success vs. failure#56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The post-setup output didn't make sense on the non-happy paths: a failed run still rendered a "You're all set" panel, the resume paths dead-ended at
uv sync, an orphaned1./2.narrative leaked into paths where the run never happened, and the agent prompt told users to "create your own pipeline" even after a failed run. This reworks the flow so the framing always matches the outcome.Changes
print_next_steps+print_resume_stepsinto one builder. Title is outcome-driven: "You're all set" only after a successful run, "Almost there" otherwise (failed run / uv declined /--scaffold-only).Finish setup) followed by the sample-run steps (What to try next) as one ordered list, instead of stopping atuv sync.1./2.numbering from the playground/agent headlines — it only lined up on the happy path and left an orphaned2.wherever the run was skipped or failed.choose_agent(ran=...)shows the "create your own pipeline into your playground" lead only after a successful run, and a neutral "set up your coding agent" lead otherwise — so the failed path no longer presumes a working demo or contradicts the "run the sample first" steps.Tests
ruffclean.rantrue/false;test_display.pyupdated for the unified builder (incl. that the finish-setup panel still points to the sample run).