feat(normalize): fail early on unsupported data type for file format#4172
Open
AshwabhB wants to merge 2 commits into
Open
feat(normalize): fail early on unsupported data type for file format#4172AshwabhB wants to merge 2 commits into
AshwabhB wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Runs the destination data-type/file-format compatibility check (
verify_supported_data_types) during normalize, so an unsupported combination fails at the normalize step instead of surfacing later at load time. Reuses the existing load-time logic unchanged, so destinations that already declare exceptions (bigquery, redshift, athena, databricks, dremio, synapse, sqlalchemy) get the earlier check for free.modelandreferencejobs are skipped since they carry no typed data file.Adds a
destination_typefield toNormalizeConfigurationso the error message can name the destination.This covers task 3 of the issue. The Snowflake
use_decfloat/parquet exception and remaining tasks will follow separately.Related Issues
loader_file_formatparameter consistent #815Additional Context
Test:
tests/normalize/test_normalize.py::test_normalize_fails_on_unsupported_data_type— bigquery cannot load ajsoncolumn fromparquet, and this now raisesUnsupportedDataTypeduring normalize. Ranmake lint(mypy/ruff/flake8/bandit/docstrings) and the affectedtest-commonpaths locally; all green.