Honor normalize loader_file_format config#4151
Open
YinkaMetrics wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds
loader_file_formattoNormalizeConfigurationsonormalize.loader_file_formatcan set the default writer format used during normalization. The existing explicit table/resource format path still takes precedence in the worker, sopipeline.run(..., loader_file_format=...)and resource-level file formats continue to win when present.The config value is validated against the known loader file formats, matching the existing pipeline argument validation behavior.
Related Issues
loader_file_formatparameter consistent #815Additional Context
This intentionally covers the normalize configuration part of #815 and does not attempt to bundle the destination-specific unsupported-type matrix into the same PR.
Validation run locally:
UV_CACHE_DIR=/Users/akanbiadeyinka/Documents/Codex/2026-07-01/search-github-for-open-source-projects/work/uv-cache uv run --extra duckdb pytest tests/pipeline/test_pipeline.py::test_file_format_resolution tests/pipeline/test_pipeline.py::test_run_file_format_sets_table_schema tests/pipeline/test_pipeline.py::test_normalize_loader_file_format_config_sets_default_format tests/normalize/test_normalize.py::test_normalize_loader_file_format_config_overrides_destination_preferenceUV_CACHE_DIR=/Users/akanbiadeyinka/Documents/Codex/2026-07-01/search-github-for-open-source-projects/work/uv-cache uv run black --check dlt/normalize/configuration.py dlt/normalize/worker.py tests/normalize/test_normalize.py tests/pipeline/test_pipeline.pyUV_CACHE_DIR=/Users/akanbiadeyinka/Documents/Codex/2026-07-01/search-github-for-open-source-projects/work/uv-cache uv run flake8 dlt/normalize/configuration.py dlt/normalize/worker.py tests/normalize/test_normalize.py tests/pipeline/test_pipeline.py