fix: avoid trailing filesystem directory probes#4122
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3866.
FilesystemClient.dataset_pathandFilesystemClient.get_table_dir()are passed directly to fsspec directory probes such asisdir()andexists(). They currently force a trailing separator, which is benign on some backends but can fail on stricter implementations such as OneLake/Fabric.This keeps the existing table-prefix behavior for layouts that need folder-style prefixes, but returns dataset/table directory paths without a trailing separator before those paths are probed or converted to remote URLs.
Validation
I also tried the full parametrized
test_filesystem_dirs_do_not_have_trailing_separatorslocally. The localdatacases passed; remote bucket cases require credentials or optional filesystem extras that are not present in my local environment.