fix: preserve incremental step order on clone#4118
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #3838.
This preserves the explicit pipe position of an existing incremental step when a resource is cloned and its hints/config wrappers are ejected and injected again. The issue was that hint-based incremental replacement during clone removed the existing incremental transform and re-added it through the default affinity-based append path, which could move user-inserted steps such as
MetricsItembefore incremental filtering.The fix records the current incremental step index before replacement/ejection and passes that index back into
set_incrementalwhen the incremental is reinserted. Normal first-time incremental insertion still uses the existing affinity behavior.Validation
uv run --with duckdb --with pyarrow --with pydantic pytest tests/extract/test_incremental.py::test_clone_preserves_inserted_step_after_hints_incremental tests/extract/test_incremental.py::test_pydantic_columns_validator tests/extract/test_extract.py::test_add_metrics tests/extract/test_extract.py::test_custom_metrics_preserved_when_all_items_filtered -q->6 passed in 1.37suv run ruff check dlt/extract/resource.py tests/extract/test_incremental.py->All checks passed!python3 -m py_compile dlt/extract/resource.py tests/extract/test_incremental.py-> passedI also ran the issue-style
pipeline.runreproduction locally after the fix and observedrow_count: 2, so the metrics step now sees only rows that survive incremental filtering.