Fix moon cycle differentiations#2
Draft
Chuddington wants to merge 17 commits into
Draft
Conversation
Author
|
Created a draft PR so the changes can be tracked. It will be marked as ready once I think it's good to go |
- This is prep work for using the ASCOM AstroUtils class that converts a Julian Date into an Angle that relates to a Moon Phase.
Owner
|
Is there anything fixed here? I only see code reorganization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project Gorgon utilises GMT / UTC to define the moon phases. However, the game itself primarily works in EST.
Once complete, this PR aims to resolve this issue.