Skip to content

Add and fix Algorithms#7

Merged
k1ngmang merged 11 commits into
dlangalgorithms:mainfrom
AripaStudio:main
Jun 15, 2026
Merged

Add and fix Algorithms#7
k1ngmang merged 11 commits into
dlangalgorithms:mainfrom
AripaStudio:main

Conversation

@AripaStudio

Copy link
Copy Markdown
Contributor

fix ceil
add floor
add round
add gcd
add lcm
add is_prime
add prime_sieve

@TolstopyatovIlya

Copy link
Copy Markdown
Contributor

In principle, everything is fine, but it is better to use /**/ in order to preserve the style, as well as asserts to package in unittests.

@AripaStudio

Copy link
Copy Markdown
Contributor Author

Hi! Thanks for the review.

I have updated the documentation comments to use the standard /** */ block format and removed the module declarations to match the project's style.

Regarding the unittests: all my assertions are already packaged inside unittest blocks. Did you mean I should completely remove the empty void main() {} function from the bottom of the files?

Please let me know so I can clean it up. Thanks!
@TolstopyatovIlya

@TolstopyatovIlya

Copy link
Copy Markdown
Contributor

I most likely confused it with unit tests, sorry.

@k1ngmang

Copy link
Copy Markdown
Member

Unfortunately, the comments still do not follow the style defined in this repository.

@AripaStudio

Copy link
Copy Markdown
Contributor Author

Unfortunately, the comments still do not follow the style defined in this repository.

Hi! I have updated all the documentation comments to match the repository's style guidelines.

@k1ngmang

Copy link
Copy Markdown
Member

Unfortunately, the comments still do not follow the style defined in this repository.

Hi! I have updated all the documentation comments to match the repository's style guidelines.

No, they don't match what's in the repository. Look at the other files, they have "@param", not "Param:", and a lot of other little things. We're not accept AI slop

@AripaStudio

Copy link
Copy Markdown
Contributor Author

Unfortunately, the comments still do not follow the style defined in this repository.

Hi! I have updated all the documentation comments to match the repository's style guidelines.

No, they don't match what's in the repository. Look at the other files, they have "@param", not "Param:", and a lot of other little things. We're not accept AI slop

Hi,

I originally used AI to help because my English isn't great, since you didn't prefer that, I manually rewrote all the comments myself using my own English and Google Translate and fixed the @param format.

@k1ngmang

Copy link
Copy Markdown
Member

You only fixed a couple of comments. Everything needs to be adapted to javadoc comment style. Check out the other examples in the repository.

@AripaStudio

Copy link
Copy Markdown
Contributor Author

You only fixed a couple of comments. Everything needs to be adapted to javadoc comment style. Check out the other examples in the repository.

Hi,

This time I learned about the standard D language format which is Ddoc and fixed everything. I also checked all files with "dmd -D -o-".

You were right, when I checked the HTML output first time it looked very wrong. Thanks for your guide.

@TolstopyatovIlya TolstopyatovIlya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these ###?

@AripaStudio

Copy link
Copy Markdown
Contributor Author

Why these ###?

HI , In Ddoc you can use Markdown, and this helps with the readability of document

@TolstopyatovIlya

Copy link
Copy Markdown
Contributor

Why these ###?

HI , In Ddoc you can use Markdown, and this helps with the readability of document

This style is not standard for the current repository

@k1ngmang

Copy link
Copy Markdown
Member

Why these ###?

HI , In Ddoc you can use Markdown, and this helps with the readability of document

This style is not standard for the current repository

We used javadoc, but I think switching everything to ddoc is a good solution.

@k1ngmang k1ngmang merged commit 5f33acc into dlangalgorithms:main Jun 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants