Add and fix Algorithms#7
Conversation
|
In principle, everything is fine, but it is better to use /**/ in order to preserve the style, as well as asserts to package in unittests. |
|
Hi! Thanks for the review. I have updated the documentation comments to use the standard Regarding the unittests: all my assertions are already packaged inside Please let me know so I can clean it up. Thanks! |
|
I most likely confused it with unit tests, sorry. |
|
Unfortunately, the comments still do not follow the style defined in this repository. |
Hi! I have updated all the documentation comments to match the repository's style guidelines. |
No, they don't match what's in the repository. Look at the other files, they have "@param", not "Param:", and a lot of other little things. We're not accept AI slop |
Hi, I originally used AI to help because my English isn't great, since you didn't prefer that, I manually rewrote all the comments myself using my own English and Google Translate and fixed the |
|
You only fixed a couple of comments. Everything needs to be adapted to javadoc comment style. Check out the other examples in the repository. |
Hi, This time I learned about the standard D language format which is Ddoc and fixed everything. I also checked all files with "dmd -D -o-". You were right, when I checked the HTML output first time it looked very wrong. Thanks for your guide. |
HI , In Ddoc you can use Markdown, and this helps with the readability of document |
This style is not standard for the current repository |
We used javadoc, but I think switching everything to ddoc is a good solution. |
fix ceil
add floor
add round
add gcd
add lcm
add is_prime
add prime_sieve