feat(windows): 트레이 런타임 제어 추가#5
Draft
dkfhddla wants to merge 1 commit into
Draft
Conversation
eedaa3e to
ef97439
Compare
a627f0e to
9703270
Compare
ef97439 to
eb89aa2
Compare
9703270 to
90b4ae5
Compare
Windows tray 런타임 제어를 macOS 복원 브랜치 위에 별도 커밋으로 다시 추가합니다. ty 검증이 통과하도록 tray 동적 객체 경계에 타입을 명시했습니다.
eb89aa2 to
4a8a419
Compare
90b4ae5 to
71e4893
Compare
dkfhddla
commented
May 13, 2026
dkfhddla
left a comment
Owner
Author
There was a problem hiding this comment.
Windows tray 런타임 제어 변경을 검토했습니다. 큰 흐름은 좋고 테스트/문서/OpenSpec도 맞춰져 있습니다. 다만 Windows 프로세스 핸들 ctypes 선언 누락은 실제 런타임 상태 오판으로 이어질 수 있어 inline으로 1건 남깁니다.
| kernel32 = ctypes.WinDLL("kernel32", use_last_error=True) | ||
| handle = kernel32.OpenProcess(process_query_limited_information, False, pid) | ||
| if not handle: | ||
| error_access_denied = 5 |
Owner
Author
There was a problem hiding this comment.
[P2] ctypes.WinDLL 함수의 restype/argtypes를 지정하지 않으면 기본 반환형이 c_int라서 64-bit Windows에서 OpenProcess가 반환한 HANDLE이 잘리거나 이후 GetExitCodeProcess/CloseHandle 호출에 잘못 전달될 수 있습니다. 이 함수가 False를 돌려주면 load_running_metadata()가 살아 있는 서버 PID 파일을 stale로 지우고 트레이에서 중복 서버 시작까지 이어질 수 있으니, OpenProcess.restype = wintypes.HANDLE 및 각 함수의 인자/반환 타입을 명시해 주세요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
변경 내용
PR 관계
검증