docs(provider): 읽기 전용 market data provider 사양 추가#25
Conversation
dkfhddla
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53d4bf4593
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - [ ] 토스증권 API는 첫 read-only provider 검증 대상으로 문서화되어 있다. | ||
| - [ ] provider adapter는 보유 종목, 현재가, KOSPI/KOSDAQ 지수를 공통 내부 모델로 정규화한다. | ||
| - [ ] provider 결과는 provider명, 데이터 출처, 마지막 갱신 시각을 포함할 수 있다. |
There was a problem hiding this comment.
RMP-003/RMP-006 require provider/source/update-time metadata to be carried and shown, but this acceptance item only says the provider result "can" include provider name, source, and last refresh time. In a provider implementation that omits these fields, the checklist could still be marked complete while the dashboard cannot satisfy the provenance/staleness guarantees added by this spec; make the acceptance criterion mandatory and include the price reference time as well.
Useful? React with 👍 / 👎.
|
|
||
| - `backend/tests`: fake provider로 보유 종목, 현재가, KOSPI/KOSDAQ 지수 정규화 테스트를 추가한다. | ||
| - `backend/tests`: 인증 실패, 권한 없음, 데이터 지연, provider 오류 상태가 안전하게 전파되는지 검증한다. | ||
| - `backend/tests`: provider 데이터로 당일 및 보유 기간 상대성과가 계산 규칙과 일치하는지 검증한다. |
There was a problem hiding this comment.
This verification expectation asks tests to compute holding-period relative performance from provider data, but the provider contract above only requires holdings/current prices/current KOSPI/KOSDAQ normalization. The existing calculation rules need the current holding period's first-buy date/price and the corresponding baseline market index, so a fake provider following this spec would have to invent missing baselines or compute against the wrong period; require those inputs/imported trades or state that holding-period relative return is UNAVAILABLE when they are absent.
Useful? React with 👍 / 👎.
1 participant
Summary
Scope
REQ-SSV-010을 추가했습니다.docs/specs/read-only-market-data-provider.md를 새로 추가했습니다.SVC-009 Market Data Providers경계를 추가했습니다.MAP.md에 새 spec 위치를 반영했습니다.Documentation impact
docs/product-requirements/stock-signal-view.mddocs/specs/read-only-market-data-provider.mddocs/arch/backend-architecture-slices.mdMAP.mdVerification
git diff --statgit status -sb문서 전용 변경이라 빌드/테스트는 실행하지 않았습니다.
Residual risks
.codegraph/디렉터리는 PR에 포함하지 않았습니다.