Multiplayer: disallow disconnection victories for co-op maps + refactor#4847
Merged
Merged
Conversation
rainlizard
changed the title
Grammar correction (infinitive form ends in -er)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue of "If all human players are allied then one leaves, all others win."
Also in addition I've added a function
are_disconnect_victories_allowed()which checks if any players have any human enemies at the start, if not then disconnections won't play into the winstate at all.Some of the leaving and disconnection code was scattered and confusing, I've centralized it with this refactor.
Removed the unused
PckA_SaveGameAndQuit.Something for mapmakers to keep in mind is the way this command works:
It checks if other keepers are "friendly or defeated", so being allied can fulfill the win condition. That means testing this PR with all players allied is a little difficult on the original MP maps because you just win instantly thanks to that DKScript.