Message box opens only for correct player

[Loobinex]

Fixes #4840

[rainlizard]

I need reproduction steps to review this. I've never seen this issue in multiplayer. Does it occur in singleplayer skirmish? Does this occur only in campaigns? Do you need special DKScript to display the objective? I don't know how that works.

I tested this fix with multiplayer and it's fine, but I don't think my test maps have objectives or something.

[PlebSupporter]

'Objective' is a type of message. It sits on the player hud as a green question mark, and they can read it at any time. For the most part the player will read it once and then dismiss it. When an active player dies, that objective windows shows itself again (when it shouldn't). It can cause confusion for players who think the objective has been updated, only to realize a few words or sentences in that they've already read that message before.

It happens everywhere. You can test by loading up any map with multiple keepers and killing one via the cheat menu. Simply having an objective on the map is enough.

You can quickly look at;
levels/standard/desperation
levels/deepdngn/korros-tor
campgns/keeporig/woodly-rhyme

[Loobinex]

I need reproduction steps to review this. I've never seen this issue in multiplayer. Does it occur in singleplayer skirmish? Does this occur only in campaigns? Do you need special DKScript to display the objective? I don't know how that works.

I tested this fix with multiplayer and it's fine, but I don't think my test maps have objectives or something.

It happens in both multi and single player.

To reproduce:

1. Have a map with an objective
2. Minimize the objective
3. Kill an enemy keeper
4. Wait a few turns, until that keeper receives the 'you have lost' objective.
   -> Notice your minimized objective is restored.

[rainlizard]

I don't see any issue, it seems to work.