review-only: mirror of upstream sidinsearch/superbrain#7 for CodeRabbit - #9
review-only: mirror of upstream sidinsearch/superbrain#7 for CodeRabbit#9djbclark wants to merge 2 commits into
Conversation
Defensive client support for config-driven categories. Without /taxonomy (upstream today), behavior matches mainline chips and sync. With /taxonomy, honor use_default_categories, taxonomy_version full-resync, and custom chips. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
- syncService.ts: the delta-sync pagination loop could spin forever if the server doesn't implement `offset` (this PR adds client-side pagination with no matching backend change). Add a hard page cap plus non-advancing- cursor detection so it terminates safely either way, warning rather than silently duplicating posts. - HomeScreen.tsx: loadCategories() and loadPosts() fired independent, redundant /taxonomy fetches when run in parallel at bootstrap (the existing taxonomyRef caching only deduped within loadPosts's own steps, not across the two functions) -- a real HTTP call doubling plus a narrow race if one fetch succeeded while the other timed out under flaky network. Fetch /taxonomy once in initializeAndLoad and share the single in-flight promise with both, each still resolving it lazily at the point they actually need it (keeps the fast local-data paint path unblocked). - api.ts: getTaxonomy()'s raw response type declared precedence/guidance as required while TaxonomyPayload declares them optional. Align them. TypeScript passes.
|
Superseded — this PR's base branch (a temp branch pinned to upstream's commit) is blocked by CodeRabbit's 'reviews disabled for this base branch' policy. Replaced by a review-only PR based on main instead (main's version of these 3 files is byte-identical to the pre-fix state, so the diff is clean — just the fix, no fork-vs-upstream noise). |
1 participant
Review-only vehicle — CodeRabbit isn't installed on the upstream repo (sidinsearch/superbrain), so this mirrors the exact same diff (base pinned to the real upstream/main commit) in the fork where CodeRabbit is active. Not intended to merge; will be closed once CodeRabbit's review lands. Real PR: sidinsearch#7