Feature/prompt user to paste code properly 35 - Take 2

[tim-schilling]

This is another attempt at #42

I squashed the commits, rebased on main, and resolved most of the mypy issues. The Plugin concerns already exist in nag, so I'm not sure how to handle those.

I also pinned the new dependency to a specific commit to help avoid security issues down the road. However, this makes the build more fragile.

[knyghty]

Thanks for having a look at this! I'll try to review in the coming days.

[knyghty]

Thanks for this. I left some comments. I am not too sure about the mypy errors relating to the plugins. For guesslang not being found you can add guesslang.* to the excludes: https://mypy.readthedocs.io/en/stable/config_file.html#confval-exclude

[knyghty]

I don't much like the name of this file, can it be utils? Or whatever is more appropriate.

[knyghty]

We're on 3.10 (which reminds me, should probably upgrade to 3.11), so we can do:

Suggested change

	def get_parser(
	message: hikari.Message,
	) -> Optional[Union[HTMLParser, PythonParser, JavascriptParser]]:
	def get_parser(
	message: hikari.Message,
	) -> HTMLParser | PythonParser | JavascriptParser || None:

Additionally... Couldn't this be:

Suggested change

	def get_parser(
	message: hikari.Message,
	) -> Optional[Union[HTMLParser, PythonParser, JavascriptParser]]:
	def get_parser(message: hikari.Message) -> CodeblockParser | None:

[knyghty]

Suggested change

	("content", Optional[str]),
	("content", str | None),

[knyghty]

Suggested change

	def codeblock(text: str, language: Language) -> Optional[str]:
	def codeblock(text: str, language: Language) -> str | None:

[knyghty]

I guess for the plugin stuff in mypy, maybe just typing.cast()ing them to callables will work?

[tim-schilling]

It's probably unlikely I'm going to get back around to this.