Skip to content

make responsive#5

Open
jeremyplichta wants to merge 5 commits into
dj1yfk:masterfrom
jeremyplichta:mobile-responsive
Open

make responsive#5
jeremyplichta wants to merge 5 commits into
dj1yfk:masterfrom
jeremyplichta:mobile-responsive

Conversation

@jeremyplichta

@jeremyplichta jeremyplichta commented Sep 2, 2024

Copy link
Copy Markdown

Main Changes

  • Changed top level main layout from using tables to header, nav, aside components
  • Changed top level main layout to use flex layout (maybe not entirely necessary but makes it a bit easier to customize)
  • Added media query css to collapse nav and menu bars and basic js to display
  • Slight modifications to lesson view to show play controls above text box in small mode

Screenshots

Screen Shot 2024-09-02 at 16 56 39

Screen Shot 2024-09-02 at 16 58 25

Screen Shot 2024-09-02 at 16 58 51

Still todo:

  • Test on actual mobile device, make sure switching to keyboard/textarea on lesson start works as expected
  • Test remaining pages for mobile layout (only courselesson looked at so far)

@jeremyplichta

Copy link
Copy Markdown
Author

Not sure what I think about the two collapsed menu bars at the top. Might play with just having one and maybe having the other main menu be a slide out from the left.

Also thinking will change collapsed top menu bar to show username and logout in it and also make sure that login form is somehow more visibly displayed without having to expand a menu.

@jeremyplichta

Copy link
Copy Markdown
Author

Updated to have a slide out side menu. Also updated groups and plaintext page to fit better on mobile. I think this is ready for comments and merge in if you are ok with it.

Screen Shot 2024-09-07 at 19 39 38

Screen Shot 2024-09-07 at 19 39 43

@jeremyplichta jeremyplichta changed the title WIP: make responsive: initial draft make responsive Sep 8, 2024
@dj1yfk

dj1yfk commented Sep 10, 2024

Copy link
Copy Markdown
Owner

Thanks, Jeremy!

Please bear with me for a few more days before I have the time to properly test and review this. I'll get back to this some time next week!

@jeremyplichta

Copy link
Copy Markdown
Author

Thanks @dj1yfk - no rush what so ever! Thanks for taking a look and for all the effort it takes to maintain this in your free time.

@georgiraychev

Copy link
Copy Markdown

@jeremyplichta just wanted to drop by and say thank you for doing this. And of course @dj1yfk for testing and reviewing.

@jeremyplichta

Copy link
Copy Markdown
Author

@dj1yfk - I got busy/distracted myself and just now remembered to check back on this. Were you able to find anything in testing? Happy to spend some more time cleaning it up if you'd like.

quanglewangle added a commit to quanglewangle/lcwo that referenced this pull request Jul 22, 2026
Working notes for a proposal to Fabian about the mobile-responsive
work on Morse Machine, course lesson, and Code Groups, including
coordination notes on the overlap with dj1yfk#5.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants