support Japanese Kana#1
Open
Luci6fuge wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks! Please allow me a few days to check the changes in detail. I am currently a little busy with other things but I won't forget it. |
Luci6fuge
commented
Jun 6, 2022
| else if (cw->encoding == UTF8) { | ||
| /* Character may be 1-byte ASCII or 2-byte UTF8 */ | ||
| if (!(c & 128)) { /* MSB = 0 -> 7bit ASCII */ | ||
| if(c < sizeof(iso8859)/sizeof(iso8859[0])) { |
Contributor
Author
There was a problem hiding this comment.
Sorry, this line is wrong. It might be
if(c < 128) {
Contributor
Author
|
Of course, no rush. By the way, your coding style is strict standard C, mine is polluted by C++. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Fabian,
I wrote an ugly patch for supporting Japanese Kana.
Please take a look.
The fuction utf8_to_ucs4() looks ugly.
I wrote it years ago, but it worked fine then.