Fix data isolation for projects#2
Conversation
- Added `organization` field to Project model - Updated project creation to link project to user's organization - Updated project listing to filter by organization, owner, or assignment - Removed permissive access for contractor/engineer roles
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses a critical data isolation issue where users (specifically contractors and engineers) could see all projects in the system.
Changes:
backend/src/models/projectModel.jsto include anorganizationfield.backend/src/controllers/projectController.js:createProject: Now associates the new project with the creating user's organization.getProjects: Removed the logic that granted unrestricted access to contractors and engineers. Instead, it now filters projects based on:assignedUsers).owner).createdBy).getProjectById: Updated access control to allow access if the project belongs to the user's organization.Verified with a reproduction script that confirmed isolation between users in different organizations and users without organizations.
PR created automatically by Jules for task 10708754394000315320 started by @dixonsilveroff