[DAP-18] TaskConf AAD: Provision in-process test task after aggregator startup#4707
Open
jcjones wants to merge 1 commit into
Open
[DAP-18] TaskConf AAD: Provision in-process test task after aggregator startup#4707jcjones wants to merge 1 commit into
jcjones wants to merge 1 commit into
Conversation
…r startup Restructure JanusInProcess to provision its task via a new provision_task() method once its ephemeral port is known, so JanusInProcessPair builds one task with consistent real endpoints and provisions both aggregator views. Doesn't do anything else.
tgeoghegan
approved these changes
Jul 10, 2026
tgeoghegan
left a comment
tgeoghegan
left a comment
Contributor
There was a problem hiding this comment.
I was sure it'd be more complicated than this, but if it works, it works.
Contributor
Author
|
When I started copying things out, I was a little surprised too that this is all that was needed. But I am sorry to say that the rest of this won't be so small. :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure
JanusInProcessto provision its task via a newprovision_task()method once its ephemeral port is known, soJanusInProcessPairbuilds one task with consistent real endpoints and provisions both aggregator views. A starting point for the AAD binding work going on over in #4698.Doesn't do anything else.