Upgrade to HPKE v0.14#109
Conversation
|
Thanks for the PR, Michael. IMO this crate's goal is just to be an adapter to We will also need to update the discussion of features in And wiring up PQ and hybrid HPKE is worthwhile. |
| rand = "0.9.2" | ||
| num_enum = "0.7.0" | ||
| cfg-if = "1.0.0" | ||
| hpke = { version = "0.13.0", default-features = false, features = ["std"] } |
There was a problem hiding this comment.
the hpke/std feature is gone, but AFAICT that's because instead of that gating an std::error::Error impl on HpkeError, that's now a core::error::Error impl that can be available unconditionally.
There was a problem hiding this comment.
We'd still need default-features = false in order for enabling hpke/x25519 etc. again to have any effect.
|
Great, I can make those changes 👍 |
|
Thanks, but let's see if @jcjones or @divergentdave have an opinion to share before we make another move. |
divergentdave
left a comment
There was a problem hiding this comment.
Mirroring hpke's features and forwarding them sounds good. Our existing per-algorithm features may have gone a bit overboard.
| rand = "0.9.2" | ||
| num_enum = "0.7.0" | ||
| cfg-if = "1.0.0" | ||
| hpke = { version = "0.13.0", default-features = false, features = ["std"] } |
There was a problem hiding this comment.
We'd still need default-features = false in order for enabling hpke/x25519 etc. again to have any effect.
Making this to start the conversation about how to upgrade. Right now it's the absolute minimum possible diff to do the upgrade. But I suspect you might want to change your own feature flags to match the new ones upstream, and also maybe add some to expose the new PQ and hybrid ciphersuites. Let me know what you're thinking