revert: remove OAuth callback deep link support#85
Conversation
Reverts the OAuth callback feature that was prematurely merged. This removes: - OAuth callback page and routing - ASWebAuthenticationSession webcredentials - iOS applinks array changes The feature is preserved in the oauth-callback-feature branch. Reverts commits: - 3bae756 Add empty apps array to applinks for iOS compatibility - ca5d436 Add webcredentials for ASWebAuthenticationSession HTTPS callbacks - 8594c31 Improve app callback fallback with platform detection - 776c947 Fix OAuth callback redirect loop - 0e3c11b Add Sha256 for test app - a5bec97 Fix unused variable lint errors - 9117483 Add OAuth callback deep link support for Divine mobile app Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
🚀 Preview Deployment
|
Deploying divine-web with
|
| Latest commit: |
06fa32f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10638b47.divine-web.pages.dev |
| Branch Preview URL: | https://revert-oauth-callback.divine-web.pages.dev |
NotThatKindOfDrLiz
changed the title
|
Self-review note: blocked by merge conflicts against current |
|
Review verdict: CLOSE (stale) (self-authored PR — posting as a comment) This revert was opened in January but never merged, and in the five months since, the OAuth callback feature it removes has stayed live on The branch is also unmergeable ( If a revert is ever needed in the future, it should be recreated fresh against current |
1 participant
Summary
The feature is preserved in the
oauth-callback-featurebranch for future use.Test plan
🤖 Generated with Claude Code