This repository was archived by the owner on Jul 15, 2025. It is now read-only.
Conversation
cvx
commented
Jun 13, 2025
cvx
commented
Contributor
- don't modify state in getters
- prefer a getter over a manually updated tracked property
- convert minimal leaderboard row to glimmer
- use qunit-dom
- use local variables over this.set
- use relative imports in tests
- add tests for minimal leaderboard
- fix a test for minimal leaderboard row
- whitespace
- remove gitkeep files
* don't modify state in getters * prefer a getter over a manually updated tracked property * convert minimal leaderboard row to glimmer * use qunit-dom * use local variables over this.set * use relative imports in tests * add tests for minimal leaderboard * fix a test for minimal leaderboard row * whitespace * remove gitkeep files
davidtaylorhq
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.