DEV: Use resolve_group_membership core theme functionality#37
Merged
Conversation
ZogStriP
approved these changes
Jul 2, 2026
See discourse/discourse#41360, group list theme settings can now use resolve_group_membership: true and a special user_in_X property will be injected on the theme settings object, so we can check this on the frontend instead of looking at currentUser.groups, which may not include all groups the user is a member of.
martin-brennan
force-pushed
the
dev/user-resolved-groups-fix
branch
from
1332922 to
5e83632
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discourse/discourse#41360,
group list theme settings can now use resolve_group_membership: true
and a special user_in_X property will be injected on the theme
settings object, so we can check this on the frontend instead
of looking at currentUser.groups, which may not include all
groups the user is a member of.