Skip to content

fix: missing Slack notifications for group request created and completed events#442

Open
elaynelemos wants to merge 1 commit into
discord:mainfrom
elaynelemos:bugfix/group-requests-notification
Open

fix: missing Slack notifications for group request created and completed events#442
elaynelemos wants to merge 1 commit into
discord:mainfrom
elaynelemos:bugfix/group-requests-notification

Conversation

@elaynelemos
Copy link
Copy Markdown

Adds the two missing hook implementations to Slack notification plugin (examples/plugins/notifications_slack/notifications.py):

  • access_group_request_created: DMs each approver, DMs the requester when they aren't already in the approver list, and posts to the alerts channel. Links to /group-requests/{id}.
  • access_group_request_completed: DMs the requester when notify_requester=True, DMs each approver other than the requester, and posts to the alerts channel. Uses the created group's name when approved, falling back to the resolved/requested name on rejection.

@somethingnew2-0 somethingnew2-0 requested a review from eguerrant May 12, 2026 17:48
@elaynelemos elaynelemos force-pushed the bugfix/group-requests-notification branch from 7c974b3 to d3c4097 Compare May 12, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant