fix: resolve failing tests across codebase#115
Open
marton78 wants to merge 8 commits into
Open
Conversation
…ctor Tool-call label changed from "Tool:" to "Tool Call", command and browser_action_launch ask labels changed to "Use tool?", and browser_action moved to the verbose-only fallback path. Update the four affected assertions in display.test.ts to match the current output.
ink v7 causes TerminalInfoProvider to emit �[16t (terminal pixel-size
query) during tests, corrupting stdout and breaking assertions. Add
vi.mock("ink-picture", ...) to App, App.resize-initial-prompt, ChatView,
and QuitCommand tests. Also rewrite QuitCommand's stdin.write-based
keyboard simulation to use a useChatInputHandler wrapper mock, which the
ink v7 event model requires.
…mock
ink v7 no longer delivers stdin events to useInput handlers via
ink-testing-library, so all keyboard-interaction tests in
SkillsPanelContent.test.tsx were failing. Replace stdin.write() calls with
a vi.mock("ink") that captures the registered useInput handler into a ref,
then invoke it directly via a pressKey() helper.
…pt text changes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…arameters Previously only added in strict mode, causing the OpenAI no-params tool test to fail. Also switches tools snapshot comparison to deep object equality so JSON property ordering no longer causes spurious failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…sage output openRouterDefaultModelInfo now has non-zero pricing, so stub models with zero prices and assert totalCost:0 explicitly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- debug_syntax: add missing messageState stub (syncCache reads conversation history) - RenameSymbol: resolve displayPath to absolute before writing in saveChanges mock, and add showReview/hideReview stubs required by the non-auto-approve path Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ialMessageIfExistsWithType
The wrapper was always passing the optional third argument explicitly, even
when undefined. sinon's calledWithExactly treats f("a","b",undefined) and
f("a","b") as different calls, causing SubagentToolHandler partial-streaming
tests to fail.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all previously failing tests through a combination of code corrections and test updates.
Changes
All tests now pass.