test: over-run polish (compound test + naming consistency)#16
Merged
Conversation
…OverRun_ for naming consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small follow-ups from PR #15's final code review:
Compound
over run AND valueengine test — the spec exampleavg(value) over run > 70 AND value > 95was covered at the parse level but not at the engine evaluation level. New testTestProcess_OverRunCompoundANDinend_of_run_test.godrives the full chain with a 4-event sequence that exercises both the false-AND-false and true-AND-true cases and verifies the right arm doesn't fire alone when the windowed left arm is below threshold.Test rename —
TestRingBuffer_RunBounded_RespectsMaxSize→TestRingBuffer_OverRun_RespectsMaxSizefor naming consistency with the spec's testing nomenclature (OverRunis the user-facing concept;RunBoundedis the implementation detail). All other related tests useOverRunin their names.Test plan
go test ./internal/evaluator/...passesgo test ./...passes (no regressions)TestProcess_OverRunCompoundANDcovers four event scenarios:Avg=82.5, Count=4Note on the third follow-up
The third item from the final review was "version bump to v0.12.0 at release time." That's a tag operation, not a code change — no separate PR commit is needed since DING's version is injected via goreleaser ldflags from the git tag (
-X main.version={{.Version}}in.goreleaser.yaml). Once this PR merges, the next step is tagging main asv0.12.0to trigger the release pipeline.🤖 Generated with Claude Code