Skip to content

arrowNext button icon no longer references arrowPrev button icon, which fixes #2172 #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dave-meyer wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −4
Open

arrowNext button icon no longer references arrowPrev button icon, which fixes #2172 #2173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/js/ui/button-arrow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ function initArrowButton(element, pswp, isNextButton) {
});
}

const iconPath = 'M29 43l-3 3-16-16 16-16 3 3-13 13 13 13z';

/** @type {UIElementData} */
export const arrowPrev = {
name: 'arrowPrev',
Expand All @@ -39,8 +41,8 @@ export const arrowPrev = {
html: {
isCustomSVG: true,
size: 60,
inner: '<path d="M29 43l-3 3-16-16 16-16 3 3-13 13 13 13z" id="pswp__icn-arrow"/>',
outlineID: 'pswp__icn-arrow'
inner: `<path d="${iconPath}" id="pswp__icn-arrow-prev"/>`,
outlineID: 'pswp__icn-arrow-prev'
},
onClick: 'prev',
onInit: initArrowButton
Expand All @@ -57,8 +59,8 @@ export const arrowNext = {
html: {
isCustomSVG: true,
size: 60,
inner: '<use xlink:href="#pswp__icn-arrow"/>',
outlineID: 'pswp__icn-arrow'
inner: `<path d="${iconPath}" id="pswp__icn-arrow-next"/>`,
outlineID: 'pswp__icn-arrow-next'
},
onClick: 'next',
onInit: (el, pswp) => {
Expand Down