Skip to content

feat: Build CommonJS files as part of dist #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loc-tran-hipages wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Build CommonJS files as part of dist #2062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion build/config-builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const minCoreJS = {
};

// UMD config
const umdBaseOutputDir = 'demo-docs-website/static/photoswipe/umd/';
const umdBaseOutputDir = `${baseOutputDir}/umd/`;
export const umdMinLightboxJS = {
input: 'src/js/lightbox/lightbox.js',
output: {
Expand All @@ -99,3 +99,24 @@ export const umdMinCoreJS = {
},
plugins: [getBabelPlugin(), getMinifyPlugin()]
};

const commonJsBaseOutputDir = `${baseOutputDir}/cjs/`;
export const lightboxCommonJS = {
input: 'src/js/lightbox/lightbox.js',
output: {
banner: getBanner('PhotoSwipe Lightbox'),
file: commonJsBaseOutputDir + 'photoswipe-lightbox.cjs',
format: 'commonjs',
sourcemap: true
}
};

export const coreCommonJS = {
input: 'src/js/photoswipe.js',
output: {
banner: getBanner('PhotoSwipe'),
file: commonJsBaseOutputDir + 'photoswipe.cjs',
format: 'commonjs',
sourcemap: true
}
};
6 changes: 4 additions & 2 deletions build/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import {
minLightboxJS,
minCoreJS,
umdMinLightboxJS,
umdMinCoreJS
umdMinCoreJS,
lightboxCommonJS,
coreCommonJS
} from './config-builder';

export default [lightboxJS, coreJS, minLightboxJS, minCoreJS, umdMinLightboxJS, umdMinCoreJS];
export default [lightboxJS, coreJS, minLightboxJS, minCoreJS, lightboxCommonJS, coreCommonJS, umdMinLightboxJS, umdMinCoreJS];
Loading