Skip to content

Remove resend_notifications_for_undelivered_messages task from cron#256

Merged
sravfeyn merged 1 commit into
mainfrom
sr/pause-retry
Jun 17, 2026
Merged

Remove resend_notifications_for_undelivered_messages task from cron#256
sravfeyn merged 1 commit into
mainfrom
sr/pause-retry

Conversation

@sravfeyn

Copy link
Copy Markdown
Member

Technical Summary

I found below on production.

>>> Message.objects.filter(received__isnull=True).count()
506131
>>> Message.objects.count()
506131

This means there is some bug in UpdateReceivedView making resend_notifications_for_undelivered_messages resend notifications for all messages. This feature worked fine before we recently fixed celery which triggered this task after a long time. So as we investigate further and fix the root cause (which we don't know yet), it's best to remove this from periodic tasks

https://dimagi.atlassian.net/browse/CI-727

Logging and monitoring

NA

Safety Assurance

Safety story

Simple change

  • I am confident that this change will not break current and/or previous versions of CommCare apps

Automated test coverage

NA

QA Plan

NA

Labels & Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@sravfeyn sravfeyn merged commit da6f58e into main Jun 17, 2026
5 checks passed
@sravfeyn sravfeyn deleted the sr/pause-retry branch June 17, 2026 08:11
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 499d08b5-7b9f-4850-bd84-d33f909228d5

📥 Commits

Reviewing files that changed from the base of the PR and between cc284e2 and 00b5367.

📒 Files selected for processing (1)
  • connectid/celery_app.py

Walkthrough

The Celery beat schedule entry for resend_notifications_for_undelivered_messages in connectid/celery_app.py has been commented out. Two TODO comments with a Jira reference were added around the disabled block. The periodic task is no longer registered in the beat schedule.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sr/pause-retry

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants