Skip to content

fix(ci): exclude the promote job's own check runs from promotion validation - #67

Merged
laurenhitchon merged 1 commit into
mainfrom
fix/promote-v1-self-check
Jul 29, 2026
Merged

fix(ci): exclude the promote job's own check runs from promotion validation#67
laurenhitchon merged 1 commit into
mainfrom
fix/promote-v1-self-check

Conversation

@laurenhitchon

Copy link
Copy Markdown
Contributor

First live promotion attempt surfaced a self-referential bug: when the target is the current main head, the promote job's own check run attaches to that commit — so validation counted itself as pending (guaranteed failure), and the failed attempt then sat on the commit as a red check, poisoning every retry. The green-check gate now filters out check runs named promote (comment notes the rename coupling). Everything else about the gate is unchanged and worked as designed.

Copilot AI review requested due to automatic review settings July 29, 2026 11:56
@DFSIdigital

DFSIdigital commented Jul 29, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@laurenhitchon
laurenhitchon merged commit 7676c5c into main Jul 29, 2026
10 checks passed
@laurenhitchon
laurenhitchon deleted the fix/promote-v1-self-check branch July 29, 2026 11:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a self-referential gating issue in the promote-v1 workflow where the promotion validation could incorrectly count the promote job’s own check run(s) on the target SHA, causing the gate to see itself as pending (and potentially blocking retries due to accumulated failures on that check name).

Changes:

  • Update the check-runs query to filter out check runs named promote before computing success/failed/pending counts.
  • Add inline documentation explaining the self-reference failure mode and the coupling to the check-run name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants