fix(ci): exclude the promote job's own check runs from promotion validation - #67
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a self-referential gating issue in the promote-v1 workflow where the promotion validation could incorrectly count the promote job’s own check run(s) on the target SHA, causing the gate to see itself as pending (and potentially blocking retries due to accumulated failures on that check name).
Changes:
- Update the check-runs query to filter out check runs named
promotebefore computing success/failed/pending counts. - Add inline documentation explaining the self-reference failure mode and the coupling to the check-run name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First live promotion attempt surfaced a self-referential bug: when the target is the current main head, the promote job's own check run attaches to that commit — so validation counted itself as pending (guaranteed failure), and the failed attempt then sat on the commit as a red check, poisoning every retry. The green-check gate now filters out check runs named
promote(comment notes the rename coupling). Everything else about the gate is unchanged and worked as designed.