feat(ci): gate v1 promotion behind a reviewed workflow and add a drift canary - #64
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
This PR formalizes and automates promotion of the mutable v1 tag (used by downstream repos to run reusable workflows) by introducing a gated, audited promotion workflow and adding a weekly drift canary to detect when main has reusable-workflow changes that haven’t been promoted.
Changes:
- Add a reviewed, environment-gated
Promote v1workflow that validates the target commit is onmainand has green checks before force-updating thev1tag. - Add a weekly “v1 drift canary” workflow that opens a single labelled tracking issue when
mainhas week-old unpromoted changes toreusable-*.yml. - Update MAINTENANCE.md to document the new promotion process, rollback, and drift detection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MAINTENANCE.md | Rewrites the v1 promotion procedure around the new workflow and documents drift + emergency fallback. |
| .github/workflows/v1-drift-canary.yml | Adds a scheduled workflow to detect and track promotion lag for reusable workflows. |
| .github/workflows/promote-v1.yml | Adds a manually triggered, environment-gated workflow to validate and move the v1 tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+38
| `main` with all checks green, the previous target is recorded in the run | ||
| summary, and the push happens over the release deploy key because | ||
| `refs/tags/v*` is ruleset-protected against manual force-push. Rollback = | ||
| re-run the workflow with the previous SHA from the last promotion's summary. |
Comment on lines
+27
to
+29
| permissions: | ||
| contents: read | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
promote-v1.yml— the new promotion path for thev1tag.workflow_dispatchwith a target SHA, gated by thev1-promotionenvironment (required reviewer), pushes overRELEASE_DEPLOY_KEY. Machine-enforces the rules MAINTENANCE.md previously left to convention: target must be onmain, all check runs green. Records the previous target in the run summary for rollback.v1-drift-canary.yml— weekly probe (same pattern as the ccc v10 canary) that opens a single labelled tracking issue whenmaincarries week-old unpromoted changes toreusable-*.yml. Renovate'schore(deps)bumps never cut a release, so nothing else prompts a promotion — observed 2026-07-29: five action majors sat onmainunpromoted with Release green.Why
v1is the ref all 24 consumers execute reusable workflows from, withsecrets: inherit. Promotion was a bare manual force-push with no gate, no audit trail, and no trigger for dependency-only changes. A follow-up adds arefs/tags/v*ruleset (DeployKey bypass) once this merges — this workflow must exist first or there is no promotion path.Notes
v1-promotionenvironment already created (required reviewer: @laurenhitchon, self-review allowed).actionlintclean.