Skip to content

build(engines): raise the Node floor to 24.15.0 - #61

Merged
laurenhitchon merged 1 commit into
mainfrom
build/engines-node-min-24-15
Jul 29, 2026
Merged

build(engines): raise the Node floor to 24.15.0#61
laurenhitchon merged 1 commit into
mainfrom
build/engines-node-min-24-15

Conversation

@laurenhitchon

Copy link
Copy Markdown
Contributor

What

Raises engines.node from >=24.0.0 <25.0.0 to >=24.15.0 <25.0.0 in package.json, and mirrors it into the lockfile's root entry.

Why

@semantic-release/changelog@7 and @semantic-release/git@11, merged in #59, both declare engines: "^22.22.2 || >=24.15". The repo's own floor was 24.0.0, so a contributor on Node 24.0–24.14 satisfied package.json but got a hard EBADENGINE install failure from engine-strict=true — reported against a transitive plugin rather than against repo policy.

CI was never exposed to this: .nvmrc pins 24.16.0. This is a local-developer ergonomics and correctness fix, not a build fix.

This also closes a gap flagged independently in the fleet review: repo-files/.npmrc sets engine-strict=true specifically so the engines floor is a hard install failure, but a floor of 24.0.0 left that control not enforcing the version the same .npmrc comment identifies as the real requirement.

Note on the lockfile diff

npm install --package-lock-only also pruned a stale "extraneous": true entry for conventional-commits-filter@6.0.1 that was already sitting in the lockfile on main. Nothing depends on it; removing it is what npm does unprompted when it rewrites the file. Called out here so the extra 10 deleted lines aren't a surprise.

Verification

  • npm ci clean on Node 24.18.0 (349 packages added, no EBADENGINE).
  • .nvmrc (24.16.0) satisfies the new floor.

Not changed

The wider fleet uses ^22.22.2 || >=24.15.0, which also admits Node 22. This repo deliberately caps at <25.0.0 and pins a 24.x .nvmrc, so this PR only raises the floor rather than adopting the fleet shape — worth a separate decision if the fleet range should be standardised here.

@semantic-release/changelog@7 and @semantic-release/git@11 (merged in #59)
declare engines "^22.22.2 || >=24.15". The repo's own floor was 24.0.0, so a
contributor on Node 24.0-24.14 satisfied package.json but hit a hard
EBADENGINE from engine-strict=true, reported against a transitive plugin
rather than repo policy. CI was never exposed: .nvmrc pins 24.16.0.

npm also pruned a stale extraneous conventional-commits-filter@6.0.1 entry
from the lockfile while rewriting the engines block.
Copilot AI review requested due to automatic review settings July 29, 2026 03:28
@DFSIdigital

DFSIdigital commented Jul 29, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Raises this repository’s declared Node.js engine floor to align with transitive engine requirements introduced by the semantic-release plugin upgrades, preventing engine-strict=true install failures for contributors on early Node 24 minors.

Changes:

  • Update package.json engines.node from >=24.0.0 <25.0.0 to >=24.15.0 <25.0.0.
  • Mirror the same engine floor in the lockfile root packages[""].engines.node.
  • Remove a stale extraneous lockfile entry (conventional-commits-filter@6.0.1) as a byproduct of lockfile rewrite.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Raises the repo’s Node engine floor to >=24.15.0 <25.0.0.
package-lock.json Mirrors the updated Node engine floor in the root package entry and prunes a stale extraneous entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@laurenhitchon
laurenhitchon merged commit b0edb8e into main Jul 29, 2026
10 checks passed
@laurenhitchon
laurenhitchon deleted the build/engines-node-min-24-15 branch July 29, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants